Skip to content

Update lint#19736

Merged
seanbudd merged 12 commits intomasterfrom
updateLint
Mar 25, 2026
Merged

Update lint#19736
seanbudd merged 12 commits intomasterfrom
updateLint

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Mar 3, 2026

This pull request updates several development dependencies and tools to their latest versions and improves markdown linting configuration. These changes help keep the development environment secure, up-to-date, and consistent, and also clarify documentation regarding updated components.

I suggest reviewing with white space changes hidden

Dependency and tool updates:

  • Updated uv to version 0.10.6 in pyproject.toml, .pre-commit-config.yaml, and ensureuv.ps1 to ensure consistency across development and CI environments. [1] [2] [3]
  • Updated ruff to version 0.15.4 in pyproject.toml and .pre-commit-config.yaml to use the latest linter improvements and bug fixes. [1] [2]
  • Updated markdownlint-cli2 to version 0.21.0 in .pre-commit-config.yaml for improved markdown linting.
  • Updated transitive dependencies with uv lock --upgrade

Markdown lint table linting:

Fixed using the following regex pattern (and similar ones):

\| *([^|]+[^ ]) *\| *([^|]+[^ ]) *\| *([^|]+[^ ]) *\| *([^|]+[^ ]) *\| *([^|]+[^ ]) *\|
| $1 | $2 | $3 | $4 | $5 |

Documentation updates:

  • Updated the changelog in user_docs/en/changes.md to reflect the new versions of Python, Ruff, and uv, providing clearer information about updated components.

Copilot AI review requested due to automatic review settings March 3, 2026 02:05
@seanbudd seanbudd requested review from a team as code owners March 3, 2026 02:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates development tooling/dependencies (uv, Ruff, markdownlint) and adjusts markdown table formatting/config to keep the repo’s dev environment consistent and lint-clean.

Changes:

  • Bumped uv and ruff versions across pyproject.toml, pre-commit hooks, scripts, and uv.lock.
  • Updated markdown linting configuration to enforce compact table formatting and reformatted affected markdown tables.
  • Applied small readability-only formatting changes (mostly parenthesized multi-line lambdas) in a few Python files/tests.

Reviewed changes

Copilot reviewed 13 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Regenerated lockfile with upgraded direct/transitive dependencies (incl. uv/ruff).
pyproject.toml Updates pinned dev tool versions for uv and ruff.
.pre-commit-config.yaml Aligns pre-commit hook revisions with updated tool versions (ruff/uv/markdownlint).
ensureuv.ps1 Updates the PowerShell-installed uv version to match the rest of the repo.
.markdownlint.jsonc Enables table-column-style rule with compact formatting.
user_docs/en/userGuide.md Reformats many tables to comply with the new markdownlint table-column rule.
user_docs/en/changes.md Updates the changelog entry to explicitly list updated component versions.
tests/unit/test_remote/test_localMachine.py Readability-only lambda formatting change.
tests/manual/nvdaUI/addonStore.md Table delimiter formatting update for markdown lint compliance.
source/gui/addonStoreGui/viewModels/store.py Readability-only formatting change for a validCheck lambda.
source/gui/addonStoreGui/controls/messageDialogs.py Readability-only formatting change for a filter lambda.
source/brailleDisplayDrivers/freedomScientific.py Simplifies formatting of bluetooth device match predicate.
source/brailleDisplayDrivers/brailliantB.py Readability-only reformat of bluetooth detection predicate.
source/_bridge/runtimes/synthDriverHost/config.py Readability-only lambda formatting change.
source/NVDAObjects/IAccessible/winword.py Readability-only lambda formatting change.
projectDocs/dev/userGuideStandards.md Updates example table formatting to match lint expectations.
projectDocs/dev/developerGuide/developerGuide.md Reformats documentation tables to match lint expectations.
projectDocs/community/expertsList.md Reformats table delimiter row to match lint expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
@seanbudd seanbudd added the blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. label Mar 3, 2026
@seanbudd seanbudd self-assigned this Mar 3, 2026
@SaschaCowley SaschaCowley marked this pull request as draft March 5, 2026 07:21
@seanbudd seanbudd added conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. and removed blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. labels Mar 5, 2026
@seanbudd seanbudd marked this pull request as ready for review March 17, 2026 05:26
@seanbudd seanbudd requested a review from SaschaCowley March 20, 2026 02:10
@seanbudd seanbudd merged commit 976f021 into master Mar 25, 2026
8 checks passed
@seanbudd seanbudd deleted the updateLint branch March 25, 2026 01:58
@github-actions github-actions bot added this to the 2026.2 milestone Mar 25, 2026
@SaschaCowley SaschaCowley mentioned this pull request Apr 1, 2026
5 tasks
SaschaCowley added a commit that referenced this pull request Apr 2, 2026
Follow-up to #19736

### Summary of the issue:

Since #19736, the title of the user guide has been "&lt;!--
markdownlint-disable-file MD060 --&gt;".

### Description of user facing changes:

The user guide's title is back to being "NVDA [version] User Guide"

### Description of developer facing changes:

Linter comment is now at bottom of file.

### Description of development approach:

Moved the linter comment to the bottom of the user guide.
I could have fixed title extraction, but that seems rather at odds with
the current sloppy approach in `md2html.py` (and elsewhere).

### Testing strategy:

Built docs from source and ensured the title was the same as the first
heading.

### Known issues with pull request:

This will break again when someone adds anything before the first
heading in `user_docs/en/userGuide.md`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants